Perfetto tracing #286
Perfetto tracing #286
Conversation
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
I don't see much value in having two separate broken-up PRs for this functionality, so let's just close #285 in favor of this one. I've left several comments. Thanks for working on this!
package.json
Outdated
| "fs-extra": "^10.0.0", | ||
| "glob": "^7.2.0", | ||
| "natural-orderby": "^2.0.3", | ||
| "path": "^0.12.7", |
There was a problem hiding this comment.
path is already part of nodejs, so let's remove this as a dependency.
src/PerfettoController.ts
Outdated
| private stopCB: (() => void) | null = null; // To store the stop callback | ||
| private selectedChannel: string = 'dev'; | ||
|
|
||
| public async startTracing(fileUriPath: string) { |
There was a problem hiding this comment.
I'm not loving the if useWebsocket else logic througout this whole file. It makes each function more complex to read. It might be better to have two separate classes, something like PerfettoWebsocketClient and PerfettoEcpClient. They'd have a common interface with methods like enable, start, stop, saveToFile, or whatever else you'd need. Then your logic in here could be much simpler. You'd instantiate the correct one when we start, and then just to this.client.doTheTHing() in these methods below.
There was a problem hiding this comment.
created a single class "PerfettoManager"
2 participants
support to connect WS and save the trace to a file